Problems with trebs IMPLEMENTED

[phoenixffyrnig]

Trebs do not transform on bridges (or in castles either).

Can they either be produced in packed state, or transformable to packed state within the castle? Otherwise, we lose a turn of movement by having to move them one square out and then pack them.

Today, I moved a treb one square out onto a self-built wooden bridge, but it wouldn't transform. It used up the action, but didn't pack. Later, I moved a packed treb onto a stone bridge as a test, and it wouldn't unpack either, but still it's action was used up.

I have not yet had the opportunity to see if they transform on pre-built bridges, or if they can attack from bridges, but I will let you know when I do.

Also, is it possible to show the range a packed treb would have when it is unpacked with the usual red squares, either both the range of 8 and 10, or just the range of 8. This would make life a lot easier

[Endru1241]

I think it's a problem with CAN_NOT_ATTACK_WHEN_GARRISONED spec. @Stratego (dev) can we somehow exclude bridges from this spec? Or maybe add another spec which would ignore this one when building has it?

[Stratego (dev)]

it is already ineffective on bridge - it is only checked in other carriers

Code: Select all

    public boolean isCarrierLetShoot(Unit garrisonedUnit) {
        return isCarrierLetCarriedUnitsToShoot && (!garrisonedUnit.hasSpecUnitAction(ESpecUnitAction.CAN_NOT_ATTACK_WHEN_GARRISONED) || isBridgeLike());
    }
    
    public boolean isBridgeLike() {
        return !isCarrierHidesCarriedUnits;
    }    
    
    

[Endru1241]

Hmm. Bad assumption. Trebuchet can attack normally on the bridge.
Besides if something prevented ability use, then it couldn't be even selected.
And right now when any unit with transformation tries to use it, while being on a bridge - animation plays, action point is used and nothing happens.
So it's transformation problem.

[Stratego (dev)]

only target terrain thingie can cause not being able to "transform" so if the target form can step in a building it will be able to transform there.
in theory

also i saw some of the trebu tranform ability not shows nice trebuchet image but a generic circular arrow - maybe something not set properly.
shall i check?

[Endru1241]

Which trebuchet? There is two, which can move on a bridge.
As for disallowing transformation - maybe it somehow reads bridge as terrain under it - water?
Beacuse ninja, immortal and ranger too cannot transform on a bridge.

[Stratego (dev)]

you are right, there was a bug i have fixed now.
it checked terrain, i removed terrain check when it is carried by a unit (braidge or any other building)

[Stratego (dev)]

i just found that trebuches was stll not able to pack inside a castle - now i ahve fixed it....