Garrisoned actions bugfix bug lol

[b2198]

I think this one was created when the bugfix to prevent units inside mantlets inside wagons to attack was applied.

test cases:


test results ("O" means passed, "X" means failed):
O, archer can't fire inside wagon
O, archer can't fire inside mantlet inside wagon
O, archer can't fire inside ger tergen cart
O, archer can't fire inside ram
O, archer can fire inside siege tower

X, archer can fire inside wagon inside TC
X, archer can fire inside mantlet inside wagon TC
X, archer can fire inside ger tergen cart inside TC
X, archer can fire inside ram inside TC

O, archer can't fire inside barcha longa
X, archer can fire inside barcha longa inside TC

O, archer can't fire inside wagon "inside" bridge
O, archer can't fire inside mantlet inside wagon "inside" bridge
O, ...ger tergen cart can't even step on bridge lol
O, archer can't fire inside ram "inside" bridge
O, archer can fire inside siege tower "inside" bridge

O, archer can't fire inside transport ship
O, archer can't fire inside wagon inside transport ship
O, archer can't fire inside mantlet inside wagon inside transport ship
O, archer can't fire inside ram inside transport ship
O, archer can fire inside war caravel

X, archer can fire inside transport ship inside TC
X, archer can fire inside wagon inside transport ship inside TC
X, archer can fire inside mantlet inside wagon inside transport ship inside TC
X, archer can fire inside ram inside transport ship inside TC
O? archer can fire inside war galleon inside TC, probably fine, since both allow carried units to attack?

O, archer can't fire inside wagon inside nordic hall
O, archer can't fire inside mantlet inside wagon inside nordic hall
O, archer can't fire inside ger tergen cart inside nordic hall
O, archer can't fire inside ram inside nordic hall

O, archer can't fire inside transport ship inside nordic hall
O, archer can't fire inside wagon inside transport ship inside nordic hall
O, archer can't fire inside mantlet inside wagon inside transport ship inside nordic hall
O, archer can't fire inside ram inside transport ship inside nordic hall
O, archer can't fire inside barcha longa inside nordic hall
O, archer can't fire inside war caravel inside nordic hall

X, archer can fire inside wagon inside guard tower
X, archer can fire inside mantlet inside wagon inside guard tower
X, archer can fire inside ger tergen cart inside guard tower
X, archer can fire inside ram inside guard tower

Conclusion: the check was probably changed from "unit can attack if immediate garrison allows" to "unit can attack if first garrison in stack allows", resulting in this new bug.

Possible solution: change the check to "unit can attack if all garrisons in stack allow"

[b2198]

Just tested abilities (but not for all cases), they seem to work like attacks in regards to this issue, with one exception, but that is expected to be an exception, since it's hard-coded: mend, which still only works if the unit is not garrisoned, "garrisoned" in a unit by stepping on it (like bridges) or garrisoned in a TC-like unit.

[godOfKings]

Doesnt seem like much of a bug to me cuz in the past i used to drag the archer from the wagon into the tc, atk with the archer, then drag the archer in the tc back into the wagon, now it is more direct without the intermediate steps, the only exception is the guard tower.... And the fact 3 wagons in a tc can allow 9 archers to atk from that tc.... ok this is a serious bug

[b2198]

Doesnt seem like much of a bug to me cuz in the past i used to drag the archer from the wagon into the tc, atk with the archer, then drag the archer in the tc back into the wagon, now it is more direct without the intermediate steps, the only exception is the guard tower.... And the fact 3 wagons in a tc can allow 9 archers to atk from that tc.... ok this is a serious bug

I don't think it's that serious actually, 9 archers attack from tc was already possible before, now it just increased that limit to 12 (4 wagons inside TC wouldn't let any of the archers inside fire until at least 1 wagon was moved elsewhere, now it doesn't need that) (also for these numbers I'm not taking into account that you can switch wagons that are not in that tc and those that are for the sake of simplicity), and let's not even start with high castles and their 15 -> 18 archers lol, but that is not really a bug, just a lack of a mechanic to prevent that.

But still not completely ignorable, since it's very easily reproducible, looks simple to fix (might not be in reality, I'm not sure how exactly this is handled in the engine) and it's a bug that increases the potential for these wagon shenanigans

[Endru1241]

I think this one was created when the bugfix to prevent units inside mantlets inside wagons to attack was applied.

test cases:


test results ("O" means passed, "X" means failed):
O, archer can't fire inside wagon
O, archer can't fire inside mantlet inside wagon
O, archer can't fire inside ger tergen cart
O, archer can't fire inside ram
O, archer can fire inside siege tower

X, archer can fire inside wagon inside TC
X, archer can fire inside mantlet inside wagon TC
X, archer can fire inside ger tergen cart inside TC
X, archer can fire inside ram inside TC

O, archer can't fire inside barcha longa
X, archer can fire inside barcha longa inside TC

O, archer can't fire inside wagon "inside" bridge
O, archer can't fire inside mantlet inside wagon "inside" bridge
O, ...ger tergen cart can't even step on bridge lol
O, archer can't fire inside ram "inside" bridge
O, archer can fire inside siege tower "inside" bridge

O, archer can't fire inside transport ship
O, archer can't fire inside wagon inside transport ship
O, archer can't fire inside mantlet inside wagon inside transport ship
O, archer can't fire inside ram inside transport ship
O, archer can fire inside war caravel

X, archer can fire inside transport ship inside TC
X, archer can fire inside wagon inside transport ship inside TC
X, archer can fire inside mantlet inside wagon inside transport ship inside TC
X, archer can fire inside ram inside transport ship inside TC
O? archer can fire inside war galleon inside TC, probably fine, since both allow carried units to attack?

O, archer can't fire inside wagon inside nordic hall
O, archer can't fire inside mantlet inside wagon inside nordic hall
O, archer can't fire inside ger tergen cart inside nordic hall
O, archer can't fire inside ram inside nordic hall

O, archer can't fire inside transport ship inside nordic hall
O, archer can't fire inside wagon inside transport ship inside nordic hall
O, archer can't fire inside mantlet inside wagon inside transport ship inside nordic hall
O, archer can't fire inside ram inside transport ship inside nordic hall
O, archer can't fire inside barcha longa inside nordic hall
O, archer can't fire inside war caravel inside nordic hall

X, archer can fire inside wagon inside guard tower
X, archer can fire inside mantlet inside wagon inside guard tower
X, archer can fire inside ger tergen cart inside guard tower
X, archer can fire inside ram inside guard tower

Conclusion: the check was probably changed from "unit can attack if immediate garrison allows" to "unit can attack if first garrison in stack allows", resulting in this new bug.

Possible solution: change the check to "unit can attack if all garrisons in stack allow"

I remember e-mailing stratego and discussing how isCarrierLetCarriedUnitsToShoot should work.
I wanted it to check all lower level garrisons and disallow shooting if any garrison in stack disallowed it.
Stratego opinion was, that if it was already possible with a little more effort (moving out of wagon and back again), then it should be allowed.

Meanwhile I think free movement from and to carriers is true case of inbalance here.
With some cost - blocking if any garrison below blocked would make much more sense.

[b2198]

Meanwhile I think free movement from and to carriers is true case of inbalance here.

Yeah, I agree on this one.