Page 1 of 1

No Hastati in Roman Produce List FIXED

Posted: Mon Oct 18, 2021 9:05 am
by Aral_Yaren
In the Roman produce list there isn't Hastati icon eventhough it's produceable.

Re: No Hastati in Roman Produce List

Posted: Mon Oct 18, 2021 10:35 am
by Endru1241
That is very weird.

@Stratego (dev) Do you have any idea what could make a unit not appear in propsheet Produces list of the budilding, that unit can be trained from?
This is the definition:
"trnBuilders":{"categories":["AND(","HIDDEN_TRAINING_CULTURAL","U_ROMAN",")"]},

Re: No Hastati in Roman Produce List

Posted: Mon Oct 18, 2021 10:50 am
by Stratego (dev)
ithink these are the things needed to be able to produce a unit:
1. shopitem owned by player
2. listed in buildables as trainable unit
3. races set properly (except in AOS)
4. the unit terrain walkability fits to building (and surrounding tiles)
5. the builders list is set properly on unit.

Re: No Hastati in Roman Produce List

Posted: Mon Oct 18, 2021 11:11 am
by Endru1241
Stratego (dev) wrote: Mon Oct 18, 2021 10:50 am ithink these are the things needed to be able to produce a unit:
1. shopitem owned by player
2. listed in buildables as trainable unit
3. races set properly (except in AOS)
4. the unit terrain walkability fits to building (and surrounding tiles)
5. the builders list is set properly on unit.
All are true (except 3.).

But there is no problem with unit being trainable.
It is OK.
When I click on unit help - prosheet shows Roman Garrison in builders section. Which is OK.

The problem is in propsheet section "Produces" of Roman Garrison. There is no Hastati shown there. Just as well as no Velites.

Re: No Hastati in Roman Produce List

Posted: Thu Oct 28, 2021 1:44 pm
by Stratego (dev)
i have no idea, atm, i need to check, if u can narrow the problem would be awesome (eg. figuring out what is the difference bets an appearing an non appearing unit and trying if set that way it shows.)

Re: No Hastati in Roman Produce List

Posted: Thu Oct 28, 2021 2:05 pm
by Endru1241
Both of those not appearing units were on the list - "listNotBuild" before update to version 1.145.
Maybe there some old remaining code somewhere?
That's the only big difference I can think of.

Re: No Hastati in Roman Produce List

Posted: Thu Oct 28, 2021 6:18 pm
by Stratego (dev)
i dont understand, why we want there be listed a non buildable unit?

it is not a bug but proper working.

(the earlier similar problem was about the mapeditor not listed the ones in "listNotToBuild" - so that was to be fixed and i fixed already)

Re: No Hastati in Roman Produce List

Posted: Thu Oct 28, 2021 7:32 pm
by makazuwr32
But it is now available for players in normal games. It is not anymore map editor unit...

Re: No Hastati in Roman Produce List

Posted: Thu Oct 28, 2021 7:40 pm
by Stratego (dev)
Endru just said they are in non buildable list - or i misunderstood?

if so than i still need help what is the difference compared to other units.

Re: No Hastati in Roman Produce List

Posted: Fri Oct 29, 2021 1:09 am
by Endru1241
Stratego (dev) wrote: Thu Oct 28, 2021 7:40 pm Endru just said they are in non buildable list - or i misunderstood?

if so than i still need help what is the difference compared to other units.
Endru1241 wrote: Thu Oct 28, 2021 2:05 pm Both of those not appearing units were on the list - "listNotBuild" before update to version 1.145.
Maybe there some old remaining code somewhere?
That's the only big difference I can think of.
Right now they are in listBuild, otherwise it wouldn't be possible to train them.
I don't see anything in json, that could cause such weird behaviour.
E.g. exactly the same trnBuilders line exists in Senator, but it appears without problems. E.g. They both have urlImage with self image reference, but I checked removing it.
I wrote it because both units are quite old (ids 174 and 175) and existed well before jsonisation, so maybe, just maybe - if I don't see a difference in json it's not in json at all, but in the code.

Re: No Hastati in Roman Produce List

Posted: Fri Oct 29, 2021 6:29 am
by Stratego (dev)
in code there is not thing left about units.
ok i will debug it then -thanks!

so again: problem is "hastati" and "Velites" not appearing in roman garrison buildlist section of its statsheet (the html based one) - right?

Re: No Hastati in Roman Produce List

Posted: Fri Oct 29, 2021 7:52 am
by Endru1241
Stratego (dev) wrote: Fri Oct 29, 2021 6:29 am in code there is not thing left about units.
ok i will debug it then -thanks!

so again: problem is "hastati" and "Velites" not appearing in roman garrison buildlist section of its statsheet (the html based one) - right?
Exactly.
Everything else seems to be OK.

Re: No Hastati in Roman Produce List

Posted: Fri Oct 29, 2021 1:58 pm
by Stratego (dev)
good news: you were to totally right, i found traces of hastati set to non buildable in code (was nto removed when we removed all units from code) now i have removed all! (may were there listed in the in-code lists of buildable-nonbuildable-techs lists!)

Re: No Hastati in Roman Produce List IMPLEMENTED

Posted: Fri Oct 29, 2021 2:56 pm
by Endru1241
So they were in completely different place, than unit definitions.
Understandable that this small line of code could be skipped.

Well, it's good you managed to find it.
Thanks.

Re: No Hastati in Roman Produce List IMPLEMENTED

Posted: Fri Oct 29, 2021 4:34 pm
by Stratego (dev)
yes, thanks! daniel