Page 1 of 1

PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 19, 2022 3:37 pm
by Stratego (dev)
Some siege/war machines like zeppelins cannons can be constructed/repair by healers - if you leave healer near (no more than 2 tiles) and leave him action in end of turn he will restore hp to this machine. So you can build mortars for one turn help this bug.

Re: PRI#9 Healer builder

Posted: Tue Apr 19, 2022 3:37 pm
by Stratego (dev)
makaw:
Healers able to repair with ability mechanical units:
:x
We are fixing this bug but it reappears over and over again... I think it will be 8th or 9th time we are trying to finally fix it.
@Savra.

Re: PRI#9 Healer builder

Posted: Tue Apr 19, 2022 3:38 pm
by Stratego (dev)
good! so a bug to fix.

ACCEPTED_SOLUTION

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Wed Apr 20, 2022 5:41 am
by Stratego (dev)
please help me me with example units (exact unit names) that is in latest update works like this.
as i have checked many and the bug does not coming.

thanks!

daniel

ps: there was a duplicate topic so i have deleted the other

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 26, 2022 5:23 pm
by Stratego (dev)
please help me me with example units so i can fix! - thanks!

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 26, 2022 6:25 pm
by Vladneral
Dwarf healers can "heal" cannons and underconstruction also he can "heal" battle zeppelins also. I think the problem in this war machines cause healers from other races too can do it if dwarf his ally.

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 26, 2022 7:28 pm
by diesel
dwarf healers also have a "mend" ability right now that heals units not mends

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 26, 2022 9:24 pm
by makazuwr32
In case of cannons specifically:
Those are counted as unique to them type of healable mechanical units so poison works on them while burning doesn't.

In case of zeppelins — it is a bug.

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 26, 2022 9:25 pm
by Stratego (dev)
Are you referring to eg. "Dwarf Priest"? (please use exact unit names so i can find easily)

if so than i am confused :
1. this unit has only healing as "default" action
2. this unit has 2 effects one called healing other called mending
so maybe this unit should really mend other units? (as it has an ability literally for that)

if so why it is problem it can mend?

(i see that a flying ornithopter should not be mended - but that will be excuded from valid targets )

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 26, 2022 9:27 pm
by Stratego (dev)
also i see other problem: dwarf cannons must not be "healable" as they are currently. ONLY mendable.
as they can be constructed too so maybe healer heals them because of this.

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 26, 2022 9:52 pm
by makazuwr32
He heals them because they have an operator who is alive.
Fullmetal cannons can't be damaged that easy, especially by fire since they are strengthened by runes. But those runes are bound to operator of cannon and thus when he dies cannon is self destroyed.

Anyway those cannons MUST be exactly HEALABLE, not mendable once they are fully constructed.
But while under construction they must not be healable.

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 26, 2022 10:05 pm
by Stratego (dev)
ok but that is impossible by engine limitation as i wrote erlier, so i have to remove the healing option as they MUST NOT be healable if they are constructible too.
(operator is no problem, we can "model" that the cannon got damaged itself not the operator)

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 26, 2022 10:09 pm
by makazuwr32
Is it possible to deny targeting under construction units for healing spell?

It is actually important since elves will also have several constructible alive plant units. Those units may be constructed but when they are finished they must not be mendable but healable.

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 26, 2022 10:10 pm
by Stratego (dev)
currently not, that is the problem.

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 26, 2022 10:11 pm
by Stratego (dev)
wait is that the healing "spell"?
i thought the default healing.

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 26, 2022 10:13 pm
by makazuwr32
If needed we may edit that "default healing" as we need.

My main concern is to disable targeting under construction units and buildings.

Same problem actually is with woodshaper and his 20% heal spell for buildings — it must not be able to target under construction units.

If this "not targeting under construction units" will be solved than we do not need to make cannons not healable, can fix woodshaper and implement some constructible plant units for elves.

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 26, 2022 10:17 pm
by makazuwr32
Stratego (dev) wrote: Tue Apr 26, 2022 10:10 pm currently not, that is the problem.
Side question:
Is it possible to disable targeting unit if unit has some specific effect on it?
And can this effect have 0 duration so when unit is constructed effect automatically ends and unit becomes viable target for spells?

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 26, 2022 10:20 pm
by Stratego (dev)
no any good solutions currently, that is why i said to remove healing
(also not seems to me too big problem these are siege unit after all - can be handled as constructs)

but i check in code how bad to remove healings on under consntruction things - needs coding surely but question how much

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 26, 2022 10:31 pm
by makazuwr32
But healing by 20% of max health great tree under construction when it will have 7200 hp will be overkill. 1440 hp per "mend"! Even dwarves will not have SUCH GODSPEED.

I hope that you will find the solution or else we would need to disable this "healing buildings" ability on woodshaper until you will find one once we will work on mega buildings.

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 26, 2022 10:36 pm
by Stratego (dev)
??
that tree also must lose healability.

so again: "constructible" units must not be healable! that is what i am saying.

so here there was used some setup that the engine can not handle - this must no happen, we should make the code change first and AFTER setting such abilities (like a healable unit is also constructible)

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Tue Apr 26, 2022 11:09 pm
by Savra
I found this:
"IS_EFFECT_NOT_FOR_UNDERCONSTR"

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Wed Apr 27, 2022 5:15 am
by Stratego (dev)
i am afraid that will not work on heal - but please try and if works than good!

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Wed Apr 27, 2022 12:05 pm
by Vladneral
I have recheck this issue.

Problem left only for:
- dwarf heavy cannon

All others are fine now.
Ah yes and i remind that you cant "heal" it normaly - only if you left any healer close (no more than 2 tiles) with left action and end the turn.

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Thu Apr 28, 2022 4:40 pm
by Stratego (dev)
thanks!

wait you have dev version?
and you downloaded and tested after this dev version update?
viewtopic.php?f=51&t=12616#p136694

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Thu Apr 28, 2022 7:31 pm
by Stratego (dev)
so - please someone confirm is Savra attempt to fix is working or not.
it is uos already in dev version.

thanks!

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Thu Apr 28, 2022 8:14 pm
by Savra
It's working for me. I tested the woodshaper out and they can't mend under construction buildings.

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Thu Apr 28, 2022 8:21 pm
by Stratego (dev)
good!

wait: "Ah yes and i remind that you cant "heal" it normaly - only if you left any healer close (no more than 2 tiles) with left action and end the turn."
you tried this literally?

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Fri Apr 29, 2022 8:47 am
by Vladneral
Yes i have dev version. But I have post this before update. So no - i dont check this after update.

Re: PRI#9 Healer builder ACCEPTED_SOLUTION

Posted: Sun May 01, 2022 9:34 am
by Stratego (dev)
ok, please somone chekc if with latest dev verison it is working or not - thanks!

daniel